Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to push fixes from a pull request #23

Open
phil-janeapp opened this issue Oct 10, 2024 · 2 comments
Open

Not able to push fixes from a pull request #23

phil-janeapp opened this issue Oct 10, 2024 · 2 comments

Comments

@phil-janeapp
Copy link

phil-janeapp commented Oct 10, 2024

Hi, and thanks for this action (and standard)! 👋

Because of how actions/checkout@v4 interacts with pull requests (it results in a git checkout in a "detached head" state) when the action runs it's not able to auto-commit the actions. For now we're using it without the autofix, but it would be nice to be able to - especially in PRs.

I haven't tested this yet, but I believe the simplest way to work around with would be by allowing users to handle the checkout themselves and indicating that the standard action doesn't need to run that. I'm happy to submit a PR for this, as well :)

@searls
Copy link
Contributor

searls commented Oct 12, 2024

Is this change to the checkout action a security thing and done by design? If so, then I guess we have to roll our own (but I'd hate to own that going forward).

Yes, PRs welcome if tests indicate this doesn't work anymore and confirms it fixes the problem!

@phil-janeapp
Copy link
Author

@searls Apologies, have been head down on a massive project and am only getting back to this now. I'll try and get you a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants