Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand pp checking #67

Open
jgabry opened this issue Mar 29, 2015 · 5 comments
Open

Expand pp checking #67

jgabry opened this issue Mar 29, 2015 · 5 comments
Assignees
Milestone

Comments

@jgabry
Copy link
Member

jgabry commented Mar 29, 2015

First version of pp checking will be included in v1.1.0 to be released soon.

Opening this issue to keep improving and expanding pp checking capabilities on the to-do list.

@jgabry jgabry self-assigned this Mar 29, 2015
@jgabry jgabry added this to the 1.2.0 milestone Mar 29, 2015
@jgabry jgabry modified the milestones: 2+, 1.2.0 Aug 8, 2015
@bgoodri
Copy link

bgoodri commented Aug 13, 2015

Also, for a stanreg object, shinystan should just call posterior_predict rather than asking the user to select the name of the posterior predictions.

@jgabry
Copy link
Member Author

jgabry commented Aug 14, 2015

Yes, good call. I will put this in the next release. Thoughts on particular
pp checking plots for rstanarm models?

If I really wanted to put some time into it I could have
shinystan automatically adjust various settings and plots for the different
rstanarm models using the info in the stanreg object to classify the model.

On Thursday, August 13, 2015, bgoodri [email protected] wrote:

Also, for a stanreg object, shinystan should just call posterior_predict
rather than asking the user to select the name of the posterior predictions.


Reply to this email directly or view it on GitHub
#67 (comment).

@bgoodri
Copy link

bgoodri commented Aug 14, 2015

I don't really know; start with just making it possible to do something
with a stanreg object because it is not going to have a drop-down entry
for y_rep. Rather than investing a lot of time customizing for stanreg
objects, it seems that you could do a fair amount of reasonable
customization just based on the class of the dependent variable.

On Thu, Aug 13, 2015 at 8:23 PM, Jonah Gabry [email protected]
wrote:

Yes, good call. I will put this in the next release. Thoughts on particular
pp checking plots for rstanarm models?

If I really wanted to put some time into it I could have
shinystan automatically adjust various settings and plots for the different
rstanarm models using the info in the stanreg object to classify the model.

On Thursday, August 13, 2015, bgoodri [email protected] wrote:

Also, for a stanreg object, shinystan should just call posterior_predict
rather than asking the user to select the name of the posterior
predictions.


Reply to this email directly or view it on GitHub
<#67 (comment)
.


Reply to this email directly or view it on GitHub
#67 (comment).

@jgabry
Copy link
Member Author

jgabry commented Aug 14, 2015

Yeah, definitely. Recognizing the dependent variable type and selecting the
content accordingly is one of the things I've been wanting to do.

On Thu, Aug 13, 2015 at 8:27 PM, bgoodri [email protected] wrote:

I don't really know; start with just making it possible to do something
with a stanreg object because it is not going to have a drop-down entry
for y_rep. Rather than investing a lot of time customizing for stanreg
objects, it seems that you could do a fair amount of reasonable
customization just based on the class of the dependent variable.

On Thu, Aug 13, 2015 at 8:23 PM, Jonah Gabry [email protected]
wrote:

Yes, good call. I will put this in the next release. Thoughts on
particular
pp checking plots for rstanarm models?

If I really wanted to put some time into it I could have
shinystan automatically adjust various settings and plots for the
different
rstanarm models using the info in the stanreg object to classify the
model.

On Thursday, August 13, 2015, bgoodri [email protected] wrote:

Also, for a stanreg object, shinystan should just call
posterior_predict
rather than asking the user to select the name of the posterior
predictions.


Reply to this email directly or view it on GitHub
<
#67 (comment)
.


Reply to this email directly or view it on GitHub
<#67 (comment)
.


Reply to this email directly or view it on GitHub
#67 (comment).

@bgoodri
Copy link

bgoodri commented Aug 14, 2015

At a minimum, a stanreg object can store its y in a canonical form for
each type of model so it is easy to use if shinystan knows those forms.

On Thu, Aug 13, 2015 at 8:37 PM, Jonah Gabry [email protected]
wrote:

Yeah, definitely. Recognizing the dependent variable type and selecting the
content accordingly is one of the things I've been wanting to do.

On Thu, Aug 13, 2015 at 8:27 PM, bgoodri [email protected] wrote:

I don't really know; start with just making it possible to do something
with a stanreg object because it is not going to have a drop-down entry
for y_rep. Rather than investing a lot of time customizing for stanreg
objects, it seems that you could do a fair amount of reasonable
customization just based on the class of the dependent variable.

On Thu, Aug 13, 2015 at 8:23 PM, Jonah Gabry [email protected]
wrote:

Yes, good call. I will put this in the next release. Thoughts on
particular
pp checking plots for rstanarm models?

If I really wanted to put some time into it I could have
shinystan automatically adjust various settings and plots for the
different
rstanarm models using the info in the stanreg object to classify the
model.

On Thursday, August 13, 2015, bgoodri [email protected]
wrote:

Also, for a stanreg object, shinystan should just call
posterior_predict
rather than asking the user to select the name of the posterior
predictions.


Reply to this email directly or view it on GitHub
<
#67 (comment)
.


Reply to this email directly or view it on GitHub
<
#67 (comment)
.


Reply to this email directly or view it on GitHub
<#67 (comment)
.


Reply to this email directly or view it on GitHub
#67 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants