Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable filtering of skills on homepage #987

Closed
3 tasks
ecurrencyhodler opened this issue Nov 22, 2023 · 12 comments · Fixed by #1045
Closed
3 tasks

Enable filtering of skills on homepage #987

ecurrencyhodler opened this issue Nov 22, 2023 · 12 comments · Fixed by #1045
Assignees
Labels
bounties bug Something isn't working Posted

Comments

@ecurrencyhodler
Copy link
Contributor

Describe the bug
Currently, I am unable to view bounties on the bounty homepage if I select a filter of a skill. It works when I select a status.

badfilter.mov

Expected behavior
When I select a skill in the filter, the page should dynamically display bounties that meet the criteria. The logic for this will be "and" instead of "or". This logic is different from the one specified in the people page in issue #986. So if multiple skills are selected, any bounty with any of the skills tagged should be displayed.

Desktop (please complete the following information):

  • Browser: Chrome

Acceptance Criteria

  • I have tested on Chrome desktop
  • I have posted a video of me selecting one skill (javascript) in the filter and the homepage dynamically displaying the bounties
  • I have posted a video of me selecting one skill (javascript + typescript) in the filter and the homepage dynamically displaying the bounties using "or" logic.
@VividhPandey003
Copy link
Contributor

Can I work on this issue.

@ecurrencyhodler ecurrencyhodler moved this from 🆕 New to ⚡️ In Progress in Bounties Platform Nov 25, 2023
@ecurrencyhodler
Copy link
Contributor Author

@VividhPandey003 you have two other pending issues. Can you address this? Once you do we can circle back to this one.

@ecurrencyhodler ecurrencyhodler moved this from ⚡️ In Progress to 🧨 To Do in Bounties Platform Nov 25, 2023
@VividhPandey003
Copy link
Contributor

Sure, this also works. Thanks. I'll be working on those issues soon.

@VividhPandey003
Copy link
Contributor

@ecurrencyhodler could you please tell me about the complexity of this issue.

@ecurrencyhodler
Copy link
Contributor Author

This should be medium complexity. It should be related to activelist.

It's located in this file: https://github.com/stakwork/sphinx-tribes/blob/db2d4e33f88d649ed00017d9a29b418dcc0be23f/frontend/app/src/people/widgetViews/WidgetSwitchViewer.tsx

And here's the function:

const activeList = [...listSource[selectedWidget]].filter(({ body }: any) => {
    const value = { ...body };
    return (
      bountyHeaderFilter(props?.checkboxIdToSelectedMap, value?.paid, !!value?.assignee) &&
      bountyHeaderLanguageFilter(value?.codingLanguage, props?.checkboxIdToSelectedMapLanguage)
    );
  });

I'm also going to reduce the bounty amount on this down to 300,000 since we helped locate the issue.

@VividhPandey003
Copy link
Contributor

Okay, Thanks. Working on it

@Vayras
Copy link
Contributor

Vayras commented Nov 30, 2023

hi @ecurrencyhodler Is this issue available to work on ? , I think I can Implement this as I have worked on something similar to this. let me know , Thanks

@ecurrencyhodler
Copy link
Contributor Author

I assigned issue and bounty to you!

@Vayras
Copy link
Contributor

Vayras commented Nov 30, 2023

@ecurrencyhodler is this issue assigned to @VividhPandey003 ?

@ecurrencyhodler
Copy link
Contributor Author

Oops @Vayras yes to vividh. Sorry.

@Vayras
Copy link
Contributor

Vayras commented Nov 30, 2023

No problem, :)

@VividhPandey003
Copy link
Contributor

VividhPandey003 commented Dec 3, 2023

@elraphty Could we please connect once when you might be free for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounties bug Something isn't working Posted
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants