Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text on mobile for "get sphinx" is not correctly sized. #752

Closed
ecurrencyhodler opened this issue Sep 27, 2023 · 4 comments · Fixed by #761
Closed

Text on mobile for "get sphinx" is not correctly sized. #752

ecurrencyhodler opened this issue Sep 27, 2023 · 4 comments · Fixed by #761
Assignees
@maradondt
Labels
bounties

Comments

@ecurrencyhodler
Copy link
Contributor

After #744, the text on mobile is not sized correctly.
IMG_3522
@ecurrencyhodler
Copy link
Contributor Author

@maradondt would you mind resolve this as a fast follow?

@ecurrencyhodler ecurrencyhodler moved this from 🆕 New to To Do in Bounties Platform Sep 27, 2023
@maradondt
Copy link
Contributor

yeah, sure

@ecurrencyhodler ecurrencyhodler moved this from To Do to 📋 Backlog in Bounties Platform Sep 29, 2023
@ecurrencyhodler
Copy link
Contributor Author

Putting this in the backlog. Maradondt submitted a small fix for the key icon at the bottom. But since mobile and desktop are leveraging the same font (#348), this is a lot bigger task than a fast follow.

@maradondt maradondt mentioned this issue Sep 29, 2023
Merged
4 tasks
@ecurrencyhodler
Copy link
Contributor Author

ecurrencyhodler commented Sep 29, 2023 •
edited
Loading

Actually it looks like the issue was "key" instead of the icon. Maradondt's pr fixes that. The android is still cut off but that's fine for mobile. We can handle it with issue #348

@ecurrencyhodler ecurrencyhodler moved this from 📋 Backlog to To Do in Bounties Platform Sep 29, 2023
@ecurrencyhodler ecurrencyhodler moved this from To Do to 🔖 In Progress in Bounties Platform Sep 29, 2023
@github-project-automation github-project-automation bot moved this from 🔖 In Progress to ✅ Done in Bounties Platform Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maradondt maradondt

Labels
bounties
Projects
Bounties Platform
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix base modal styles for support icons maradondt/sphinx-tribes
2 participants
@maradondt @ecurrencyhodler