Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Postgres DB Before Go Tests, And Drop After Tests #1693

Closed
4 tasks
elraphty opened this issue Jun 14, 2024 · 0 comments · Fixed by #1692
Closed
4 tasks

Create Postgres DB Before Go Tests, And Drop After Tests #1693

elraphty opened this issue Jun 14, 2024 · 0 comments · Fixed by #1692
Assignees
Labels

Comments

@elraphty
Copy link
Contributor

Context

Currently, .github/prjob_tests.yml runs the Golang test in GitHub Workflow, the tests use a Mock DB so we don't need to spin up any database before the test is run. We want to move the tests from using a Mock DB to a real Postgres DB so we have to have a running DB before the Golang test runs.

Design

So we want to update the Golang test .github/prjob_tests.yml Github workflow to create a database before the test using the test db docker-compose file docker/testdb-docker-compose.yml and drop the database after successfully running the tests.

Acceptance Criteria

  • I've tested on Chrome
  • I've created a test that...
  • I have rebased and tested locally before submitting my PR
  • I can submit a PR within 1 day of taking the bounty

Here is an example backend test

@elraphty elraphty self-assigned this Jun 14, 2024
@elraphty elraphty mentioned this issue Jun 14, 2024
4 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Bounties Platform Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant