Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperAdmin] Add optional word clause to query for providers #1547

Closed
5 tasks
ecurrencyhodler opened this issue Feb 21, 2024 · 5 comments · Fixed by #1552
Closed
5 tasks

[SuperAdmin] Add optional word clause to query for providers #1547

ecurrencyhodler opened this issue Feb 21, 2024 · 5 comments · Fixed by #1552
Assignees

Comments

@ecurrencyhodler
Copy link
Contributor

ecurrencyhodler commented Feb 21, 2024

Context

I'd like to be able to filter for providers when looking at bounties inside of superadmin.

We are currently grabbing bounties using this call: metrics/bounties.

Add an optional word clause to search for providers and their bounties only. In other words, don’t search for anything other than the selected providers and their bounties within a given date range.

Also enable "or" statements so that multiple providers and the bounties they posted are returned.

Design

This is what the frontend will look like for reference (without the search bar).
Screenshot 2024-02-21 at 1 54 51 PM

Acceptance Criteria

  • I've tested on Chrome
  • I've created mock db with 3 different providers each with 2 bounties.
  • I've created a test asserting the response we get from the call only returns bounties from selected providers.
  • I have rebased and tested locally before submitting my PR
  • I can submit a pr within 2 days of taking the bounty

Here is an example backend test

@FaisalIqbal211
Copy link
Contributor

@ecurrencyhodler assign me?

@ecurrencyhodler ecurrencyhodler changed the title [SuperAdmin] Add optional word clause to query [SuperAdmin] Add optional word clause to query for providers Feb 21, 2024
@ecurrencyhodler ecurrencyhodler moved this from 🆕 New to 🧨 To Do in Bounties Platform Feb 21, 2024
@ecurrencyhodler
Copy link
Contributor Author

It's yours @FaisalIqbal211 let's get a PR up within 2 days.

@FaisalIqbal211
Copy link
Contributor

@ecurrencyhodler Just want to confirm, provider means the owner of bounty. Am I correct?

@ecurrencyhodler
Copy link
Contributor Author

Yup that's correct. The person who created the bounty.

@ecurrencyhodler
Copy link
Contributor Author

Paid 200k sats! https://community.sphinx.chat/bounty/1557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants