Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Backend Functionality People Skill Search #1473

Closed
3 tasks
elraphty opened this issue Jan 29, 2024 · 1 comment · Fixed by #1480
Closed
3 tasks

Make Backend Functionality People Skill Search #1473

elraphty opened this issue Jan 29, 2024 · 1 comment · Fixed by #1480
Assignees
Milestone

Comments

@elraphty
Copy link
Contributor

Context

At the moment the people skill search is done using an array filter on the tribes-frontend, which will only search the paginated array.

Design

The Skill search should be done in the backend, so a global search can be carried out for people based on the skill value.

https://github.com/stakwork/sphinx-tribes/blob/4e2c767260915dff9573ee5f1832778e8b421ac5/db/db.go GetAllBounties() has an example implementation for searching bounties skill

Acceptance Criteria

  • I've tested on Chrome
  • I've submitted a screenshot or recording in my pr
  • I've created a unit test that tests that people are displayed based on skill values submitted.

Here is an example unit test

Here is an example component test

@wright-eric
Copy link
Contributor

assign

@ecurrencyhodler ecurrencyhodler moved this from 🆕 New to ⚡️ In Progress in Bounties Platform Jan 29, 2024
@github-project-automation github-project-automation bot moved this from ⚡️ In Progress to ✅ Done in Bounties Platform Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants