[Feature] Add GitHub as a new source type in Add Content flow
#2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tomsmith8, @Rassl, Please review this PR. |
MirzaHanan
force-pushed
the
Add-github-source-type
branch
from
1f01cf9 to
5266478
Compare
Rassl
reviewed
Sep 19, 2024
.github/workflows/test.yml
Outdated
| @@ -85,6 +85,7 @@ jobs: | |||
| wait-on-timeout: 120 # Waits for 2 minutes | |||
| # Records to Cypress Dashboard | |||
| record: true | |||
| args: --disable-dev-shm-usage | |||
There was a problem hiding this comment.
are you aware of what this is doing?
There was a problem hiding this comment.
@Rassl, I removed it
MirzaHanan
force-pushed
the
Add-github-source-type
branch
from
5266478 to
e052889
Compare
Rassl
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
closes: #2166
Issue ticket number and link:
Evidence:
chrome_xbmDrunt4d.mp4