Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter with no search or word param should not use sort_by score #2566

Open
tomsmith8 opened this issue Dec 20, 2024 · 2 comments · May be fixed by #2568
Open

Filter with no search or word param should not use sort_by score #2566

tomsmith8 opened this issue Dec 20, 2024 · 2 comments · May be fixed by #2568
Assignees
@Ekep-Obasi
Labels
Bounty bug Something isn't working

Comments

@tomsmith8
Copy link
Contributor

tomsmith8 commented Dec 20, 2024 •
edited
Loading

  • Tap filter
  • Tap a node type
  • execute 'Apply'
  • request uses sort_byscore

If no search or word param, we should sort_by date_added_to_graph as default:

Image
@Ekep-Obasi
Copy link
Contributor

@tomsmith8 Please assign me

@MirzaHanan
Copy link
Contributor

@tomsmith8 assign me?

@tomsmith8 tomsmith8 added bug Something isn't working Bounty labels Dec 20, 2024
@tomsmith8 tomsmith8 changed the title Filter with no search should not use score Filter with no search or word param should not use score Dec 20, 2024
@tomsmith8 tomsmith8 changed the title Filter with no search or word param should not use score Filter with no search or word param should not use sort_by score Dec 20, 2024
@Ekep-Obasi Ekep-Obasi linked a pull request Dec 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ekep-Obasi Ekep-Obasi

Labels
Bounty bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sort to date_added_to_graph when no search params is provided Ekep-Obasi/sphinx-nav-fiber
3 participants
@MirzaHanan @Ekep-Obasi @tomsmith8