Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph Ontologoy] Add node_key dropdown #2521

Open
tomsmith8 opened this issue Dec 9, 2024 · 9 comments · May be fixed by #2555
Open

[Graph Ontologoy] Add node_key dropdown #2521

tomsmith8 opened this issue Dec 9, 2024 · 9 comments · May be fixed by #2555
Assignees
Labels

Comments

@tomsmith8
Copy link
Contributor

tomsmith8 commented Dec 9, 2024

Task

Add Node Key dropdown to graph ontology section above Indexes component.

image
  1. Component Design
  • Add a new dropdown UI element styled like the Indexes dropdown.
  • The dropdown supports multi-select and defaults to name.
  • Filter the properties to include only required properties (those without a ?).
  • Render this dropdown before the existing Indexes dropdown.
  1. Dropdown Behavior
  • Default Selection: Preselect name as the default option.
  • Multi-select Format: Allow users to select multiple options. Combine selected keys using - as a separator (e.g., name-age).
  • Validation: Ensure optional properties (those with ?) are not displayed.
  1. API Integration
  • For the POST or PUT requests to the /schema endpoint:

When one key is selected:

{
  "node_key": "name"
}

When multiple keys are selected:

{
  "node_key": "name-age"
}
  1. Workflow for Rendering Required Properties
  • Parse the schema to extract properties.
  • Identify required properties by checking for the absence of ?.
  • Populate the dropdown options dynamically with these required properties.
  1. Styling and Placement
  • Ensure consistent styling with the Indexes dropdown component (e.g., font, size, and border).
  • Position the new dropdown directly above or before the Indexes dropdown in the UI layout.
  1. Testing
  • Verify:
  • Dropdown renders only required properties.
  • Default selection is name.
  • Multiple selections are correctly formatted with -.
  • Confirm correct payload format for API requests.
@jordan-ae
Copy link
Contributor

I can help

@b4s36t4
Copy link

b4s36t4 commented Dec 9, 2024

Can I get assigned!?

@MuhammadUmer44
Copy link
Contributor

Hi @tomsmith8, I am available and will make a PR today.

@MahtabBukhari
Copy link
Contributor

@tomsmith8 Could you please assign me?

@tomsmith8
Copy link
Contributor Author

@b4s36t4 hey! are you on Sphinx and the Sphinx Bounty site?

@MuhammadUmer44
Copy link
Contributor

@tomsmith8 Please assign me?

@b4s36t4
Copy link

b4s36t4 commented Dec 10, 2024

Hi @tomsmith8 no I'm not. I tried to join but invite code shown in the website is not working. Can you guide me on how to join sphinx?

@tomsmith8
Copy link
Contributor Author

tomsmith8 commented Dec 10, 2024

Please email me at [email protected]

@b4s36t4
Copy link

b4s36t4 commented Dec 10, 2024

Sent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants