Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run lint to run eslint #86

Open
4 of 5 tasks
connerdavis47 opened this issue Mar 5, 2022 · 3 comments
Open
4 of 5 tasks

npm run lint to run eslint #86

connerdavis47 opened this issue Mar 5, 2022 · 3 comments
Assignees
Labels
CI/CD Automation for development procedures small

Comments

@connerdavis47
Copy link

connerdavis47 commented Mar 5, 2022

We have config for eslint right now in the VSCode settings file. I would like to propose the following changes:

package.json

  • Add eslint, @typescript-eslint/eslint-plugin, @typescript-eslint/parser to devDependencies
  • Add an eslintConfig section (see Configuring ESLint) migrating the rules specified in .vscode/settings
  • Create a lint script to automatically run eslint
  • Finally, add eslint-plugin-prettier
  • Resolve existing eslint errors and warnings

Currently there are 5 ESLint errors and 19 warnings, but none are meaningful -- just unused variables and usages of var instead of let or const. So there is no need for a substantial rewrite.

This will set us up to be able to automate ESLint with Github Actions.

@connerdavis47 connerdavis47 added small CI/CD Automation for development procedures labels Mar 5, 2022
@connerdavis47 connerdavis47 self-assigned this Mar 5, 2022
@connerdavis47
Copy link
Author

I'm working on this here: https://github.com/connergdavis/wagyu-installer/tree/feature/npm-run-lint

I still need to resolve the existing errors and warnings so we can integrate with Github Actions.

@remyroy
Copy link
Member

remyroy commented Mar 16, 2022

Good stuff. I'm sure this will improve our code quality in the long run. I'm eager to see this in motion.

@AbhinavMir
Copy link

Seems to not be closed yet, can hop on if still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Automation for development procedures small
Projects
None yet
Development

No branches or pull requests

3 participants