If miner has no mining key set, automatically set it to node seed #5498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASuciuX
commented
Nov 22, 2024
| @@ -2546,6 +2551,13 @@ pub struct MinerConfigFile { | |||
|
|
|||
| impl MinerConfigFile { | |||
| fn into_config_default(self, miner_default_config: MinerConfig) -> Result<MinerConfig, String> { | |||
| match &self.mining_key { | |||
There was a problem hiding this comment.
As long as a node.seed is set up, this will never trigger. Should it be removed? Or do we prefer this and remove the mining-key being automatically set?
There was a problem hiding this comment.
What if node.seed isn't configured and the node doesn't have miner.seed = true - will this cause the node to panic?
There was a problem hiding this comment.
I've tested it using stacks-regtest-env for the config with
node.miner = falseandnode.seedempty with miner config data in itnode.miner = falseandnode.seedempty without miner config in it specified.node.miner = trueandnode.seedspecifiednode.miner = trueandminer.mining_keyspecified
On all these cases it didn't panic.
It only panicked when node.miner = true and node.seed and miner.mining_key were not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mining_keyis not set #5473.Also, if
node.seedis specified, the miner will use that as theminer.mining_key.Tested using stacks-regtest-env.