-
Notifications
You must be signed in to change notification settings - Fork 199
Use long derivation paths for App Private Keys (courtesy of blockstack.js) #1496
base: develop
Are you sure you want to change the base?
Conversation
… as much as possible to BlockstackWallet.
I've expanded this PR to use |
Because |
This is updated to work with the latest from this PR: hirosystems/stacks.js#433 I recommend testing this by restoring an old account, logging into multiplayer apps (which should continue to work with the same app private key that you used before if you had previously logged in) and single player apps, and by creating a new user and logging in and out of apps. |
Nope -- as far as I understand, we still are using the short app derivation paths. |
@kantai What's the main benefit here? Stronger security or? |
Yep -- this would increase the security of the app-derived keys. |
@kantai Sounds good – it seems this PR is almost across the finish line and just needs a bit more testing. Is that the case? I'm moving this to the backlog so we can prioritize for the next sprint assuming that's the case. |
Unless I'm mistaken, this is not backwards compatible with single-player apps, because they aren't in the |
This adds support for longer derivation paths for app private keys (#1367)
This maintains quasi-backwards compatibility by
apps
keyTo test this, you'll need to
npm link
in the wallet support branch onblockstack.js
(ordevelop
once it's merged).