Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickTile is broken for terminator on XFCE #41

Closed
karamfil opened this issue May 15, 2014 · 12 comments
Closed

QuickTile is broken for terminator on XFCE #41

karamfil opened this issue May 15, 2014 · 12 comments

Comments

@karamfil
Copy link

Firt let me say this is an awesome app!!! Keep up with the good work!

Hi, I have a problem with terminator (https://launchpad.net/terminator, 0.96-r1 and 0.97-r1) and quicktile (0.2.2 and 0.1.5) on xfce 4.10.

I have quicktile started as daemon and when I focus terminator and try to tile it - the windows jumps and starts sliding (like an animation) until only the title bar is visible.

Here is screenshot before tiling
terminator-normal

Here is a screenshot trying to tile terminator to top-left
terminator-topleft

Debug info (seems perfectly fine):

Xlib.protocol.request.QueryExtension
DEBUG: window: <wnck.Window object at 0xfac280 (WnckWindow at 0x1039ab0)>
DEBUG: Monitor: 1, gtk.gdk.Rectangle(1920, 0, 1920, 1080)
DEBUG: dims [[0, 0, 960, 513], [0, 0, 640, 513], [0, 0, 1280, 513]]
DEBUG: result (1920, 27, 960, 513)
DEBUG: Monitor: 1, gtk.gdk.Rectangle(1920, 0, 1920, 1080)
DEBUG: repositioning to (1920, 27, 960, 513)

If there is any more info I can provide please point me in the right direction. I will try to help as much as possible.

Thanks in advance!

@ssokolow
Copy link
Owner

I'm a bit overworked right now but I'll try to make time to look into it on the weekend.

I generally try to reproduce people's problems by reproducing their desktops in VirtualBox so "more info I can provide" would consist of what distro you're running and any relevant details on how you set it up. (eg. 3rd-party package sources, desktop configuration settings like "focus follows mouse", etc.)

@karamfil
Copy link
Author

Hmm let me try to make vbox vm for you :)

@ssokolow
Copy link
Owner

Thanks. That'll make things a lot simpler on my end.

@mrdanbrooks
Copy link

+1

@meoso
Copy link

meoso commented Aug 11, 2014

I've had this same problem for probably a year, i thought it was just my machine until i recently installed Debian Jessie+Xfce on another machine and it also happens. It's ONLY for TERMINATOR on Xfce. Thank you!

@ssokolow
Copy link
Owner

Originally, I was waiting for @karamfil to make the vbox VM he said he would. Now, I'm still squashing regressions on my PC after upgrading Lubuntu to 14.04 but I'll try to put this on the TODO list for some time in the near future.

@ssokolow
Copy link
Owner

Alright. I'm going to try to reproduce the problem tonight. I'm running LXDE and Terminator has no problem under LXDE so I've started torrenting a Xubuntu ISO to set up in VirtualBox.

@ssokolow
Copy link
Owner

Ok, I've reproduced the problem and it's as you said. Sorry for the wait. (I've also managed to get it to animate itself to a vertical sliver along the left edge.)

As far as I can tell, it's a Terminator bug for three reasons:

  1. In my tests, sometimes the bug triggers, sometimes the window tiles properly. In both cases, QuickTile is receiving identical metadata and sending identical instructions. That indicates it's not QuickTile's fault.
  2. Once the bug has been triggered and the animation is in progress, Xfwm's more limited built-in tiling support also suffers from it. That means that, if it is an Xfwm bug, asking Xfwm itself to do tiling doesn't snap the window out of it.
  3. The animation ignores the Xfwm "Hide content of windows: When resizing" option, which means that Xfwm doesn't consider the animation a resize.

My best guess is that the Terminator bug gets it stuck in a loop something like this:

  1. Terminator receives notice that it's been resized
  2. For some reason, Terminator decides it wants to be one pixel smaller than the size Xfwm reported
  3. Terminator asks to be resized to its desired size.
  4. Go back to step 1 (If Terminator's height is already at minimum, then asking for a smaller size does nothing and the loop stops.)

This could technically be considered a bug in either Xfwm or Terminator, since both seem to be required for the problem to manifest, but Terminator is the most at fault since I can't trigger it with anything else.

Either way, this isn't something I can fix and you'll want to follow the instructions for reporting bugs in Terminator.

ssokolow pushed a commit that referenced this issue Aug 25, 2014
@meoso
Copy link

meoso commented Aug 25, 2014

thank you for locating root cause.
i've opened bug # 1361252 with terminator:
https://bugs.launchpad.net/terminator/+bug/1361252

@meoso
Copy link

meoso commented Sep 22, 2014

Stephen Boddy has presented a resolution @ https://bugs.launchpad.net/terminator/+bug/1361252/comments/1

In short, Terminator>Preferences>Global>Window geometry hints>OFF

@karamfil
Copy link
Author

Hi guys! Sorry I did not provide a VM T_T, been extremely busy this year.
Thanks a lot for taking a look at the issue again.

YOU ARE TOTALLY AWESOME!

@ssokolow
Copy link
Owner

No problem. I know how that feels. In fact, issues #44 and #45 went from tons of progress to two months of nothing because the holidays slammed me hard. I'm hoping to get them fixed in January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants