Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't leak local error details to remote peers #75

Open
staltz opened this issue Jun 29, 2021 · 0 comments
Open

Don't leak local error details to remote peers #75

staltz opened this issue Jun 29, 2021 · 0 comments
Assignees
@staltz
Labels
bug

Comments

@staltz
Copy link
Member

staltz commented Jun 29, 2021

This line https://github.com/ssb-js/muxrpc/blob/805a2d708925ef280b00c16562bebb3af74c34e0/stream.js#L35 passes on stack trace details (which contains filesystem paths that may leak which OS and application is used) from the local machine to the remote peer. It should probably be cb(err.message) instead.
@staltz staltz added the bug label Jun 29, 2021
@staltz staltz self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staltz staltz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@staltz