Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in "box packer" script #30

Open
trickeydan opened this issue Oct 13, 2019 · 5 comments
Open

Merge in "box packer" script #30

trickeydan opened this issue Oct 13, 2019 · 5 comments

Comments

@trickeydan
Copy link
Contributor

@kierdavis wrote a box packing script for kit packing. We should merge it in here.

@kierdavis kierdavis changed the title Merge in Kiers "box packer" script Merge in "box packer" script Oct 14, 2019
@kierdavis
Copy link
Contributor

The script is currently here: https://gist.github.com/kierdavis/ddd6da1c76119841264f20cdaee1958d

Note that this isn't a matter of downloading and committing the file - it really needs a lot of polish and should talk directly to the rest of this package to operate the inventory rather than calling out to subcommands. I'd recommend the script be used as a proof-of-concept/reference implementation for creating a new sr pack-kit command (or something similar).

@trickeydan
Copy link
Contributor Author

We used this again for SR2022.

@PeterJCLaw
Copy link
Member

One thing which would be good to do before merging into the shared tools would be to separate out the specification for what should go in the box from the implementing code. Otherwise we end up with tooling that's tied to a specific year's kit.

@trickeydan
Copy link
Contributor Author

separate out the specification for what should go in the box from the implementing code.

So I don't think we can put that in the inventory repo yet? For the same reason as we can't add a README?

We could bake a definition file into this package but that doesn't feel right.

@PeterJCLaw
Copy link
Member

I think there's some space in the .meta directory which we could put things like this -- I believe that directory isn't searched for part files (only templates), so ought to be able to not break things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants