Skip to content
This repository has been archived by the owner on May 22, 2022. It is now read-only.

Create a pull request template #30

Open
raccube opened this issue May 14, 2021 · 3 comments
Open

Create a pull request template #30

raccube opened this issue May 14, 2021 · 3 comments

Comments

@raccube
Copy link
Member

raccube commented May 14, 2021

We need a pull request template which prompts the user to test their change and asks which platforms the change was tested on.

@trickeydan
Copy link
Contributor

## Platforms Affected

- [ ] ODROID U3
- [ ] Raspberry Pi 3/3B+
- [ ] Raspberry Pi 4

## Checklist

- [ ] I have updated the relevant documentation
- [ ] I have tested builds of my changes on all affected platforms
- [ ] I would like multiple reviewers to approve my code before merging

## Why do you want to make these changes?


## Which parts of the build process do your changes affect?


## Do your changes affect student or volunteer experience? How so?


## Are your changes related to any existing issues or PRs? How so?

@raccube
Copy link
Member Author

raccube commented May 14, 2021

Shouldn't the first section be called Tested Platforms instead?

@raccube
Copy link
Member Author

raccube commented May 14, 2021

Although whoever is reviewing should test it themselves as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants