Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues / finalize Ghost setup #312

Open
vcoisne opened this issue Sep 16, 2019 · 16 comments
Open

Fix issues / finalize Ghost setup #312

vcoisne opened this issue Sep 16, 2019 · 16 comments
Assignees
@znegrin

Comments

@vcoisne
Copy link
Contributor

vcoisne commented Sep 16, 2019

Thank you @vmarkovtsev for creating this doc with the list of tasks left to finalize a proper ghost setup

https://docs.google.com/spreadsheets/d/15ysW90Onf5cdYV-4SXd-JK7YzjOkLLq8EX6VUbgA4eg/edit#gid=0

@znegrin please review and let me know if you have any questions. More context in this issue: #282
@dpordomingo dpordomingo transferred this issue from src-d/landing Sep 17, 2019
@znegrin
Copy link

znegrin commented Oct 7, 2019

Hi @vcoisne,

I just tried to go and check the document but I have no permission. I just asked for it.

Thank you.

@vmarkovtsev
Copy link
Contributor

Permissions have been granted.

@znegrin
Copy link

znegrin commented Oct 7, 2019 via email

@znegrin
Copy link

znegrin commented Oct 8, 2019 •
edited
Loading

I am checking the blog issues and in terms of the code insertion, it seems that it wasn't inserted as in the example post. The blog theme is powered with prism.js, which allows to insert the code as a markdown block as explained here:

https://www.matthiggins.dev/ghost-cms-and-syntax-highlighting/

Basically it needs to be introduced with:

``` followed by the language type, e.g. ```language-javascript

I can check the posts with issues to see if I can fix them.

@znegrin
Copy link

znegrin commented Oct 8, 2019

The headers are now fixed. It seems that there was a bug on the theme headers making them uppercase but it is now solved.

image

@znegrin
Copy link

znegrin commented Oct 8, 2019

I added a fix to make all code blocks work fine, event without using prism.js on markdown, although it would be the best option for a proper highlight of the code.

image

@vcoisne
Copy link
Contributor Author

vcoisne commented Oct 9, 2019

Thank you @znegrin

If I am following correctly, minus some minor formatting issues (which I can take care of fixing myself), it looks like the only ghost setup issue left is:

  • Math formulas as Images: Looks like MathJax might be able to solve this issue. Can you take a look at it @znegrin?

cc @vmarkovtsev

@vcoisne
Copy link
Contributor Author

vcoisne commented Oct 11, 2019

Ping @znegrin @vmarkovtsev ?

@znegrin
Copy link

znegrin commented Oct 14, 2019

Hi @vcoisne,

It is now integrated on the blog. I made a quick test to check it out:

image

To make it sure that it works, the formula code must be inserted as a markdown block.

@vmarkovtsev
Copy link
Contributor

Please let me know if something particular is waiting for my review @znegrin

@znegrin
Copy link

znegrin commented Oct 21, 2019

Hi @vmarkovtsev,

I basically reviewed and fixed the design issues on the blog side.
It probably needs some work on individual posts to make them look better but now from the template side, everything is ready. I fixed these points:

  • Code blocks background is now working as expected. If using markdown with a language type tag, it will also be highlighted.

  • Code vertical and horizontal scroll is now fixed too.

  • I fixed the bug that was showing the titles in uppercase.

  • I added the proper code to add formulas in markdown using MathJax.

The other issues are meant to be fixed in the content of the individual posts.
Please let me know if there is something else design related that need fixing by my side.

Thank you!

@vmarkovtsev
Copy link
Contributor

@znegrin Regarding the code blocks, the scrollbars should be hidden if they are not needed. For example, at https://blog.sourced.tech/post/handshakes_pagerank/

image

@vmarkovtsev
Copy link
Contributor

vmarkovtsev commented Oct 21, 2019 •
edited
Loading

@znegrin I guess that the following items are design-related:

Regarding the headers, please @ricardobaeta correct me if I am wrong but this is a feature, not a bug.

  • The title of the blog post in <body> must be all lower-case, so css text-transform
  • The title of the blog post in <header> which is shown in the browser's tab must be normal Camel Case.

@vmarkovtsev
Copy link
Contributor

@vcoisne The main complexity now seems to be in porting LaTeX from the old posts. I wonder if we can find somebody to freelance this.

@vcoisne
Copy link
Contributor Author

vcoisne commented Oct 22, 2019

@vmarkovtsev @znegrin integrated MathJax so do we need LaTex ? Happy to help with the updates to get it over with once for all :)

@vmarkovtsev
Copy link
Contributor

@vcoisne MathJax is a rendering engine for LaTeX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@znegrin znegrin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vmarkovtsev @vcoisne @znegrin