Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction listener is not called properly with nested transactions #539

Closed
oleksandr-semenov opened this issue Mar 3, 2021 · 4 comments
Labels
stale This issue lacks recent activity.

Comments

@oleksandr-semenov
Copy link

Expected Behavior

When using nested transactions listener is called each time when the outer or inner transaction starts and ends/rolls back

Actual Behavior

The listener is not called in an expected way

Steps to Reproduce

Launch code with the nested transaction and observe the behavior
sqlcipher/sqlcipher-android-tests#39

SQLCipher version (can be identified by executing PRAGMA cipher_version;):
4.4.2 community

SQLCipher for Android version:
4.4.2

Note:
AndroidX SQLite database works as expected and dispatches all callbacks for nested and outer transactions.

@oleksandr-semenov
Copy link
Author

Android tests: sqlcipher/sqlcipher-android-tests#39

@developernotes
Copy link
Member

Hello @oleksandr-semenov

Unfortunately, the current Java implementation used within SQLCipher for Android does not allow nesting SQLiteTransactionListener instances (i.e., it only allows for tracking a single listener, however, nested transactions are allowed). The current Google implementation of android.database.sqlite appears to support this via embedding the listener into a transaction object managed via a session connection pool. This may be something we revisit in a future release.

We will leave this ticket open for for review and further discussion in the future.

@stale
Copy link

stale bot commented Jun 3, 2021

Hello, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "bug", "enhancement", or "security" and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale This issue lacks recent activity. label Jun 3, 2021
@stale
Copy link

stale bot commented Jun 23, 2021

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to reopen with up-to-date information.

@stale stale bot closed this as completed Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue lacks recent activity.
Projects
None yet
Development

No branches or pull requests

2 participants