This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Added implementation for Tuple with up to 3 items #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems right to me, can you add one or two tests for it? They don't need to be complicated. |
|
I have implemented the Tuple class which can now create any tuple of any size if the developer follows the Tuple class creation rules for c#. I also added in the Tuple.Create method which means the Tuple class should now be completely usable if I didn't miss anything. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I could tell Tuple is not implemented (I get Not Implemented errors when I use it). This isn't really a complete pull request. I added the implementation for Tuple but I'm not sure if I did it the way you guys would like me to do it. Could you just look over this and let me know if I'm on the right track and if I am I'll finish the implementation for up to 8 or 9 items. Thanks