Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

Implemented Regex.IsMatch(string, string) #1012

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wklingler
Copy link

No description provided.

@kg
Copy link
Member

kg commented Jul 20, 2016

I'm not sure I like this, isn't ecmascript regex mode different from the .net default? This would break app logic

  • kg (mobile)

@kg
Copy link
Member

kg commented Jul 21, 2016

Hmm, that's probably close enough. I'll think about merging it. Thanks!

@wklingler
Copy link
Author

Is there something that makes you nervous that I could look into more?

@kg
Copy link
Member

kg commented Jul 21, 2016

I'm pretty sure there are some cases where .NET regex syntax would parse but produce the wrong results in javascript, which could cause very confusing failures.
It would be ideal to write a .NET regex parser that rejects incompatible regexes. This might be OK though

@wklingler
Copy link
Author

That makes sense. I'll see if I can come up with something like that sometime.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants