Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme not working on Windows 10 #91

Open
ghost opened this issue Jan 14, 2018 · 5 comments
Open

Light theme not working on Windows 10 #91

ghost opened this issue Jan 14, 2018 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 14, 2018

Hi,

I just wanted to start by saying thank you for making those themes available to us, they look great!

I have been trying to use the "Light" theme, however it doesn't display right on Windows 10.

  • The top bar, where the tabs are, isn't dark grey like it is supposed to be and is simply white.
  • The highlight color is blue instead of orange.
  • The folder icons that are supposed to be dark grey are white on white. The other icons seem to be displayed the intended way.

Strangely enough, the other themes seem to be working fine for me but I would like to be able to use the "Light" one, as it is the one I prefer out of all of them.

Here is a screenshot of the way the "Light" theme looks on my end:

theme

And here is a comparison screenshot between the way the theme is displayed on my end, and the preview of how the theme should look:

theme_comparison

I thank you in advance.

@ghost ghost changed the title Light theme not working on Windows Light theme not working on Windows 10 Jan 14, 2018
@Rolf-Herbert
Copy link

Same for me, no rollover highlight either

@conema conema mentioned this issue Feb 6, 2018
@conema
Copy link
Contributor

conema commented Feb 6, 2018

Hi @RaceWish @TeamKinetic, these issues should be resolved in #93, let me know if it works.

@ghost
Copy link
Author

ghost commented Feb 6, 2018

Hi,

I applied the changes, and it seems to work fine now besides the tabs.
The font is basically dark gray on dark gray, which means that it's pretty much impossible to read them.
It is also quite hard to make out where the tabs are due to them being the exact same color as the title bar. Perhaps the color separating the "inactive" tabs needs to be fixed.

Here is a screenshot:
broken tabs

Thank you!

Edit: Apologies for closing and re-opening, I clicked the close button by accident.

@ghost ghost closed this as completed Feb 6, 2018
@ghost ghost reopened this Feb 6, 2018
@conema
Copy link
Contributor

conema commented Feb 7, 2018

Hi @RaceWish, I edited the last PR with some more fixes, these should resolve the folder text color and some other minor issues.
Edit: new PR #94
immagine

@ghost
Copy link
Author

ghost commented Feb 20, 2018

Hi @conema,

Thank you for your answer, your edits have indeed fixed the issue for me!
If I may make two final suggestions for this theme.

Perhaps the line that separates two inactive gray tabs could/should be more visible:

tabs_new

My second suggestion would be to make the top bar of the "Write new mail" window have the same color as the top bar of the main Thunderbird window.

new_mail_window

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants