Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version compatible with Thunderbird 60.x #109

Open
conema opened this issue Aug 18, 2018 · 2 comments
Open

New version compatible with Thunderbird 60.x #109

conema opened this issue Aug 18, 2018 · 2 comments

Comments

@conema
Copy link
Contributor

conema commented Aug 18, 2018

I think that spymastermatt is a little busy and at the moment he can't accept new PR with fixes.

For that, I created a new version of this theme that is compatible and tested with the new version of Thunderbird (60.x), for the moment. It should be compatible with 50.x

The installation is easier than before, the new theme is an Add-On and it can be downloaded directly from the Thunderbird site with one click.

More information and the download link can be found in:
dark
full dark

@lindhe
Copy link

lindhe commented Aug 19, 2018

I would suggest making it a real PR even if the maintainer might not have time to merge it. It would make more more semantic sense to me, so we can put improvements and discussion in that thread.

@conema
Copy link
Contributor Author

conema commented Aug 19, 2018

The "problem" is that the theme in my repo is not a fork of this one, but a fork of this work, they have almost nothing in common: different license and only a dozen lines of code comes from this repo. In reality, only the design is the same, but the code is practically all different.

An other problem is that, there will exists 3 repository for the 3 different version of the theme (dark/fulldark/light), because for how the addons are built in Thunderbird, I have not the possibility to create only one addon, so only one repo, with all the 3 versions inside, unlike spymastermatt's repo. Thus I find misleading create a PR with "my dark version" -> "spymastermatt's version with dark/fulldark/light".

I opened an issue, and not a PR, because I wanted only to inform users using this theme that I was working at a new version that is being maintained and that is compatible with the last version of Thunderbird.

I hope that I've made my point, I would prefer to continue the discussion of the projects in my repos, but anyway, I haven't any sort of problem to create a PR. If you still advise me to do a PR, I will do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants