Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCDF 2.10.x. and 2.11.x doesn't allow define schedule with Cron Expression CRON_TZ=CET 37 04 * * * #5774

Closed
szopal opened this issue Apr 10, 2024 · 4 comments

Comments

@szopal
Copy link

szopal commented Apr 10, 2024

From kubernetes 1.29 it doesn't support CRON_TZ expression.

https://www.yuribacciarini.com/k8s-setup-timezone-on-cronjob/

It seem's that SCDF has old library from fabric8 because I can't see propertise withTimeZone in KubernetesScheduler in library

	<dependency>
		<groupId>io.fabric8</groupId>
		<artifactId>kubernetes-client</artifactId>
		<version>${kubernetes-fabric8-client.version}</version>
	</dependency>

at version

<kubernetes-fabric8-client.version>5.12.4</kubernetes-fabric8-client.version>

This property I can see in 6.10.0

image

So after upgrade kubernetes to 1.29 we don't have possibility to create scheduler in our time zone.

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Apr 10, 2024
@corneil
Copy link
Contributor

corneil commented Apr 11, 2024

Create issue in spring-cloud-deployer#445

@cppwfs cppwfs removed the status/need-triage Team needs to triage and take a first look label Apr 22, 2024
@cppwfs cppwfs added this to the 3.0.x milestone Apr 22, 2024
@corneil
Copy link
Contributor

corneil commented May 8, 2024

According to k8s specification timezone isn't supported:

CronJob limitations
Unsupported TimeZone specification
Specifying a timezone using CRON_TZ or TZ variables inside .spec.schedule is not officially supported (and never has been).

Starting with Kubernetes 1.29 if you try to set a schedule that includes TZ or CRON_TZ timezone specification, Kubernetes will fail to create the resource with a validation error. Updates to CronJobs already using TZ or CRON_TZ will continue to report a warning to the client.

@corneil corneil removed this from the 3.0.x milestone May 8, 2024
@cppwfs
Copy link
Contributor

cppwfs commented May 29, 2024

Closing this issue. If this issue was closed incorrectly please add a comment. Thank you for raising the issue!

@cppwfs cppwfs closed this as completed May 29, 2024
@szopal
Copy link
Author

szopal commented Dec 16, 2024

Why not add a custom parameter to enable support for the timeZone parameter in an earlier version of SCDF and the Fabric8 library?
KubernetesScheduler.class:

    	if (properties.getTimeZone() != null) {
	      	if (cronJob.getSpec().getAdditionalProperties() == null) {
		    	cronJob.getSpec().setAdditionalProperties(new HashMap<>());
	      	}
	      	cronJob.getSpec().getAdditionalProperties().put("timeZone", properties.getTimeZone());
	    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants