Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Dataflow dependency management hierarchy #5490

Open
4 tasks
onobc opened this issue Oct 3, 2023 · 3 comments
Open
4 tasks

Refactor the Dataflow dependency management hierarchy #5490

onobc opened this issue Oct 3, 2023 · 3 comments
Milestone

Comments

@onobc
Copy link
Contributor

onobc commented Oct 3, 2023

There are currently multiple locations where versions are managed in the Dataflow monorepo.

  • Produce a hierarchy diagram clearly showing the parent/child/import relationships of all modules in the monorepo
  • Based on the above, consolidate the version management into a single location.
  • As we refactor let's add TODO comment on custom version overrides in hopes that we remove it once it is properly managed by the upstream library (ie Spring Boot)
  • From a 15minute glance, it seems that almost everything either inherits (ultimately) from either spring-cloud-dataflow-parent or spring-cloud-dataflow-build-dependencies. The twist to the above is that all Skipper modules have parent = spring-cloud-skipper-parent EXCEPT the special snowflake spring-cloud-skipper-server which has parent = spring-cloud-dataflow-parent. It would be ideal if all Skipper modules inherited the same parent.

Here is the commit that shows where the versions had to be overidden.

@onobc onobc added the status/need-triage Team needs to triage and take a first look label Oct 3, 2023
@onobc onobc added this to the 2.11.x milestone Oct 3, 2023
@onobc onobc self-assigned this Oct 3, 2023
@onobc onobc modified the milestones: 2.11.x, 2.11.1 Oct 3, 2023
@onobc onobc removed their assignment Oct 3, 2023
@onobc onobc modified the milestones: 2.11.1, 2.11.x Oct 3, 2023
@cppwfs cppwfs added for/team-attention For team attention and removed status/need-triage Team needs to triage and take a first look labels Oct 6, 2023
@klopfdreh
Copy link
Contributor

klopfdreh commented Oct 26, 2023

Hey @onobc does this belongs to #5405 - or do you mean the hierarchies in general?

@onobc
Copy link
Contributor Author

onobc commented Oct 31, 2023

Hi @klopfdreh , this is more of a general review of the modules inter-dependencies from when we did the move to the monorepo. It needs a review and most likely a refactoring.

@github-actions github-actions bot added status/need-feedback Calling participant to provide feedback and removed for/team-attention For team attention labels Oct 31, 2023
@klopfdreh
Copy link
Contributor

Thanks for the clarification. 👍

@cppwfs cppwfs removed the status/need-feedback Calling participant to provide feedback label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants