You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are currently multiple locations where versions are managed in the Dataflow monorepo.
Produce a hierarchy diagram clearly showing the parent/child/import relationships of all modules in the monorepo
Based on the above, consolidate the version management into a single location.
As we refactor let's add TODO comment on custom version overrides in hopes that we remove it once it is properly managed by the upstream library (ie Spring Boot)
From a 15minute glance, it seems that almost everything either inherits (ultimately) from either spring-cloud-dataflow-parent or spring-cloud-dataflow-build-dependencies. The twist to the above is that all Skipper modules have parent = spring-cloud-skipper-parentEXCEPT the special snowflake spring-cloud-skipper-server which has parent = spring-cloud-dataflow-parent. It would be ideal if all Skipper modules inherited the same parent.
Here is the commit that shows where the versions had to be overidden.
The text was updated successfully, but these errors were encountered:
Hi @klopfdreh , this is more of a general review of the modules inter-dependencies from when we did the move to the monorepo. It needs a review and most likely a refactoring.
There are currently multiple locations where versions are managed in the Dataflow monorepo.
spring-cloud-dataflow-parent
orspring-cloud-dataflow-build-dependencies
. The twist to the above is that all Skipper modules have parent =spring-cloud-skipper-parent
EXCEPT the special snowflakespring-cloud-skipper-server
which has parent =spring-cloud-dataflow-parent
. It would be ideal if all Skipper modules inherited the same parent.Here is the commit that shows where the versions had to be overidden.
The text was updated successfully, but these errors were encountered: