Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot prefixes not updated when user selects different Boot version #5470

Closed
onobc opened this issue Sep 16, 2023 · 4 comments
Closed

Boot prefixes not updated when user selects different Boot version #5470

onobc opened this issue Sep 16, 2023 · 4 comments
Labels
status/need-triage Team needs to triage and take a first look

Comments

@onobc
Copy link
Contributor

onobc commented Sep 16, 2023

Steps to reproduce

  1. Fresh SCDF 2.11.0 install
  2. Register task2 apps
    task.timestamp=maven://io.spring:timestamp-task:2.0.2
    task.timestamp.bootVersion=2
    task.timestamp-batch=maven://io.spring:timestamp-batch-task:2.0.2
    task.timestamp-batch.bootVersion=2
    
  3. Register task3 apps
    task.timestamp=maven://io.spring:timestamp-task:3.0.0
    task.timestamp.bootVersion=3
    task.timestamp-batch=maven://io.spring:timestamp-batch-task:3.0.0
    task.timestamp-batch.bootVersion=3
    
  4. Make task3 apps the default (manage versions view)
  5. Create simple timestamp task definition timestamp w/ name "taskTwo"
  6. Choose launch task
  7. In launch view notice the default version (boot3) is pre-selected - keep that selection
  8. Click "Launch Task"
  9. VERIFY: In task execution view that is shown, prefixes must be BOOT3
  10. Select "Relaunch Task"
  11. In launch view, notice the prefix properties are shown w/ expected boot3 values.
  12. Select the boot2 version of the app in the drop-down.
    PROBLEM: The prefix properties are not updated (still show boot3).
  13. Click "Launch Task"
  14. VERIFY: In task execution view that is shown, prefixes must be BOOT2

GOOD: Even though the UI shows incorrect prefixes, the backend uses the proper BOOT2 prefixes.

@onobc onobc added the status/need-triage Team needs to triage and take a first look label Sep 16, 2023
@onobc onobc added this to the 2.11.x milestone Sep 16, 2023
@claudiahub
Copy link

@onobc I've verified this using dataflow server v. 2.11.0 .
If I go through all the steps, after updating the app version from 3.0.0 to 2.0.2 I am able to see the launch view with the updated boot2 prefixes as expected.
See screenshot below. The only thing relevant to be worked is the dropdown in the launch view but this is tracked here #5469.
Screenshot 2023-09-20 alle 10 44 55
Maybe you're referring to other prefixes in another view ?

@corneil
Copy link
Contributor

corneil commented Sep 20, 2023

The following list of properties are determined by the backend and cannot be set by the user.
spring.cloud.task.schemaTarget, spring.cloud.task.tablePrefix,spring.cloud.deployer.bootVersion, spring.batch.jdbc.table-prefix, spring.batch.jdbc.tablePrefix
I would suggest removing the following properties when the version changes or at the start of launch.

@onobc
Copy link
Contributor Author

onobc commented Sep 20, 2023

If they truly can never be set by the end user it would make sense to not surface them.

@markpollack
Copy link
Contributor

closed in favor of #5482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-triage Team needs to triage and take a first look
Projects
None yet
Development

No branches or pull requests

4 participants