fix: possible out of memory error #5413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: This might only optimize the performance on DB server but not cause the JVM to raise an OutOfMemoryError. I try to figure out what's the real cause and if I find something I am going to push it into this branch. |
|
We can revisted once we have done testing on the support for Boot 3 workloads with new Spring Batch and Spring Cloud Task schemas. |
Thanks a lot! 👍 |
|
@corneil the out of memory issue did not happened with 2.11.0 anymore. I am going to close this PR as it only changes the SQLs slightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes: #5409
As of https://dataschool.com/how-to-teach-people-sql/difference-between-where-and-on-in-sql/ some databases might join before filter which might cause out of memory exceptions because all task manifests are load.