-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: UnexpectedTaskExecutionException #5402
feature: UnexpectedTaskExecutionException #5402
Conversation
@cppwfs - This PR is also mentioned for the time period after 2.11.0, but in general - does the change looks fine for you? |
Thank you for the contribution. LGTM. But I want to test it once we get PR 5404 merged. |
Great! Thanks in advance for testing it! 👍 |
Hi @klopfdreh , should not be a problem. If we run into any issues we will ping back here. |
Sure - at any time 👍 |
HI @klopfdreh , Just wanted to give you a heads up, we are shipping a very quick |
Thanks for the information! 👍 |
Hi @klopfdreh , do you mind rebasing against main? |
...ingframework/cloud/dataflow/composedtaskrunner/support/UnexpectedTaskExecutionException.java
Show resolved
Hide resolved
...ingframework/cloud/dataflow/composedtaskrunner/support/UnexpectedTaskExecutionException.java
Outdated
Show resolved
Hide resolved
4defa79
to
81bdc43
Compare
Done - let's see what the CI does and if all tests are running as expected. I force-pushed the changes based on the current main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @klopfdreh. Awesome work!
It would be great if the CTR throws an
UnexpectedTaskExecutionException
in favor ofUnexpectedJobExecutionException
so that it is possible to create anApplicationListener
which can handle certain error causes.Because the
TaskExecution
itself is not serializable, the fields are assigned to theUnexpectedTaskExecutionException
.If this code is fine for you it also needs to be merged into: #5368
The
UnexpectedTaskExecutionException
also uses theExitCodeGenerator
interface so that the error code of a task which has failed is also forwarded through the CTR to its caller.If the exit code is
null
, theUnexpectedTaskExecutionException
returns-1