Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataflow-rest-client : Auto create "TASK*" tables when connect database #4940

Open
getChan opened this issue Jun 7, 2022 · 4 comments
Open
Labels
type/bug Is a bug report

Comments

@getChan
Copy link

getChan commented Jun 7, 2022

sorry about not good english

Problem description

when
add dataflow-rest-client dependency and connect database
image

then
some tables are created
image

maybe these tables are from spring-cloud-task-core dependency
image

defined at
https://github.com/spring-cloud/spring-cloud-task/blob/main/spring-cloud-task-core/src/main/resources/org/springframework/cloud/task/schema-mysql.sql

I think rest-client shouldn't handle db tables.. thanks

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jun 7, 2022
@getChan getChan changed the title dataflow-rest-client : Auto create "TASK*" tables when use jdbc connection dataflow-rest-client : Auto create "TASK*" tables when connect database Jun 7, 2022
@markpollack markpollack added this to the 2.10.0-M2 milestone Jul 20, 2022
@markpollack markpollack added type/bug Is a bug report type/enhancement Is an enhancement request and removed status/need-triage Team needs to triage and take a first look type/bug Is a bug report labels Jul 20, 2022
@markpollack
Copy link
Contributor

We will look into fixing this, thanks for the report. In the meantime can you set the property spring.cloud.task.initialize-enabled=false

@markpollack markpollack modified the milestones: 2.10.0-M2, 2.10.0-M3 Aug 17, 2022
@markpollack markpollack added type/bug Is a bug report and removed type/enhancement Is an enhancement request labels Sep 29, 2022
@markpollack markpollack modified the milestones: 2.10.0-M3, 2.10.0-RC1 Oct 7, 2022
@onobc onobc modified the milestones: 2.10.0-RC1, 2.10.0-RC2 Oct 21, 2022
@markpollack markpollack modified the milestones: 2.10.0-RC2, 2.10.1 Nov 10, 2022
@cppwfs
Copy link
Contributor

cppwfs commented Nov 14, 2022

Did a little digging here: The issue is that SimpleTaskAutoconfiguration is included in the Spring-Cloud-Task-Core module and it fires automatically unless it is excluded for example: @SpringBootApplication(exclude = SimpleTaskAutoConfiguration.class) or set spring.cloud.task.initialize-enabled=false.
I did try to exclude it in the DataFlowClientAutoConfiguration but that has side effects because we'd have to change the configuration to autoconfiguration.

@nightswimmings
Copy link

nightswimmings commented Oct 2, 2023

@markpollack Is spring.cloud.task.autconfiguration: false equally valid? I mean does DataFlowClientAutoConfiguration depend on Cloud Task autoconfiguration in any way or can it work standalone?. If not, I think it should

@cppwfs
Copy link
Contributor

cppwfs commented Oct 2, 2023

I believe it can be excluded. But need to verify .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Is a bug report
Projects
None yet
Development

No branches or pull requests

5 participants