Update task execution list #1997
Conversation
|
We also need a change in task.service.ts |
| @@ -44,14 +44,14 @@ export class TaskService { | |||
| params = params.append('sort', `${sort},${order}`); | |||
| } | |||
| return this.httpClient | |||
| .get<any>(UrlUtilities.calculateBaseApiUrl() + 'tasks/definitions', {headers, params}) | |||
| .get<any>(UrlUtilities.calculateBaseApiUrl() + 'tasks/executions', {headers, params}) | |||
There was a problem hiding this comment.
Why these changes? I was only expecting tasks/executions in getExecutions to become tasks/thinexecutions
|
@corneil when reading the description on #1996 (comment) (see the first comment) |
That link was added in case you wanted to use it to retrieve the detail. I believe the UI already has an approach in place which works and does the same thing. When people use the REST API and previously used |
| .pipe(map(TaskPage.parse), catchError(ErrorUtils.catchError)); | ||
| } | ||
|
|
||
| getTask(name: string, manifest = false): Observable<Task | unknown> { | ||
| const headers = HttpUtils.getDefaultHttpHeaders(); | ||
| return this.httpClient | ||
| .get<any>(UrlUtilities.calculateBaseApiUrl() + `tasks/definitions/${name}?manifest=${manifest}`, {headers}) | ||
| .get<any>(UrlUtilities.calculateBaseApiUrl() + `tasks/executions/${name}?manifest=${manifest}`, {headers}) |
There was a problem hiding this comment.
Do these represent an old error that didn't surface?
|
Close for #1998 |
Resolves #1996