Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Invitation API issue #10

Open
bbaia opened this issue Feb 12, 2012 · 4 comments
Open

Invitation API issue #10

bbaia opened this issue Feb 12, 2012 · 4 comments

Comments

@bbaia
Copy link

bbaia commented Feb 12, 2012

Hi,

CommunicationOperations.ConnectTo methods does not generate JSON correctly:
Property names "item-content", "invitation-request" and "connect-type" are expected to be generated but was "itemContent", "invitationRequest" and "connectType".

  • Bruno
@habuma
Copy link
Contributor

habuma commented Feb 14, 2012

Thanks for pointing this out. I've created https://jira.springsource.org/browse/SOCIALLI-17 to address this issue.

@habuma
Copy link
Contributor

habuma commented Feb 14, 2012

Bruno: I see that you are correct regarding those fields not being put into the JSON correctly and intend to fix it. But I was wondering if this actually causes any trouble and, if so, what goes wrong. The reason I ask is that I just now successfully sent an invitation using the unchanged code. I was hoping something would've broken that way I'd have some way of knowing for sure when I got it right. Did you see any errors or did you just notice that the fields are incorrect?

@habuma
Copy link
Contributor

habuma commented Feb 14, 2012

FYI, I also noticed the firstName and lastName fields on the Person (for an email-based invitation) were also incorrect...and have fixed them.

@bbaia
Copy link
Author

bbaia commented Feb 15, 2012

I just notice that the fields are incorrect, did not test.
I just fixed them in the .NET implementation to avoid any surprises. I also changed how the request body was generated by using a custom JSON serializer instead of matching the json format with multiple classes.

bclozel added a commit that referenced this issue Oct 29, 2014
Fix directory name for sample pages
spring-builds pushed a commit that referenced this issue May 10, 2017
spring-builds pushed a commit that referenced this issue May 10, 2017
Expose RestOperations through Facebook interface
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants