-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated API #27
Updated API #27
Conversation
andriidem308
commented
Jun 24, 2024
- fixed issue with Twisted
- added new messages
- fixed issue with Twisted - added new messages
samples/ConsoleSample/main.py
Outdated
|
||
def executeUserCommand(): | ||
try: | ||
print("\n") | ||
userInput = inputimeout("Command (ex help): ", timeout=18) | ||
userInput = inputimeout("Command (ex help): ", timeout=180) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting timeout too high will cause disconnection because it will keep the thread busy and while waiting for user input we can't send heartbeat to server, please set it back to 18 or find a better way to handle this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Please also update poetry version in build backend of pyroject.toml to:
This will allow installing package in editable mode via Pip. |
- updated poetry
done |