Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack speed #1

Open
VoidLock92 opened this issue Jan 29, 2022 · 4 comments
Open

Attack speed #1

VoidLock92 opened this issue Jan 29, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@VoidLock92
Copy link

Right now if you spam click, it would appear that the offhand weapon dmg is used at full atk power. I can spam click with a strong axe in offhand and it will do full dmg killing things very very fast. It would be a lot more balanced if you still had to wait for the weapon in the offhand to fully recharge for it to do full dmg. Also currently the only attack speed taken in to effect is the mainhand so if you use a very slow wep in offhand and a fast wep in the mainhand then you can do a lot of dmg much faster.

@spoorn spoorn added the enhancement New feature or request label Jan 30, 2022
@spoorn
Copy link
Owner

spoorn commented Jan 30, 2022

  1. I'm unable to reproduce the spam click issue you described. I equipped a 10 damage weapon on my offhand, but my damage per hit is only 4. Spam clicking with a regular Diamond sword is ~2 damage per hit, so it's adding up correctly for me. Could you showcase the issue if you're still having problems? There's a target dummy mod that might help: https://www.curseforge.com/minecraft/mc-mods/mmmmmmmmmmmm

  2. Yes, currently only the attack speed of the mainhand weapon is considered. That might be related to (1). Balancing damage of the offhand weapon would require me to keep track of separate cooldowns of both weapons. I may add this later

@VoidLock92
Copy link
Author

Hmm, maybe it is adding up correct when spamming, its just 2 really hard hitting weps with sharpness on them so it is better to just spam click and still do a lot of dmg but faster so it ends up being worth it to spam click if that makes sense. I am on a training dummy now and it does show much lower when spamming. I hope that makes sense. It ends up doing more damage per second when spamming than waiting for full recharge due to this. I am trying to figure out a way to balance it besides just lowering the dmg of the offhand weapon.

Maybe there could be an option to make the weapon recharge use the slower of the 2 weapons as apposed to main hand recharge? This would solve people using slow hard hitter in offhand. Just an idea. This ticket was not meant to be a suggestion ticket lol. I am just trying to find a solution to any way of exploiting this method of fighting. On that same note would be kinda cool to have a option to parry with them. Such as right clicking would cross the 2 weapons in front of you and be a form of block that maybe let some of the dmg through? Again this was not meant to be a suggestion :P

Trying to figure out how to balance it is all. Thanks for your time and the amazing mod!

@spoorn
Copy link
Owner

spoorn commented Jan 30, 2022

One thing you could do to balance it better is to change the damage multiplier of the offhand weapon, so even if you spam with 2 hard hitting weapons, it won't add too much damage.

I'd need to take some time to implement the cooldown feature.

Parrying is a good idea

@VoidLock92
Copy link
Author

VoidLock92 commented Jan 30, 2022

I have the multiplier at 0.5 so 50% weapon dmg right now but bypassing the weapon cooldown of strong hitting enchanted axes still is more damage per second than waiting for cooldown. So I guess I would either need to turn off off hand enchants or lower the dmg even more to account for the axes hit dmg. But then it will be nerfing the swords and normal weapons very much.

Some implementation like this in the config options
https://www.curseforge.com/minecraft/mc-mods/no-weak-attack
could help stop the cheese dmg from spam clicking. Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants