Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for ScalarValue #1462

Open
3 tasks
gatesn opened this issue Nov 24, 2024 · 0 comments
Open
3 tasks

Proposal for ScalarValue #1462

gatesn opened this issue Nov 24, 2024 · 0 comments

Comments

@gatesn
Copy link
Contributor

gatesn commented Nov 24, 2024

I haven't run through how viable these are in combination... but here's some ideas

  • Scalar::value to be pub(crate), to force users to use BoolScalar::try_from(&scalar) etc.
  • To either not implement (my preference), or to properly implement, PartialOrd and PartialEq for ScalarValue that ignores the actual int width of PValue.
  • Scalars to have as_primitive, as_primitive_opt functions to downcast for access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant