Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify an acceptable modified date in the Vagrantfile #2

Open
patcon opened this issue Jun 5, 2013 · 1 comment
Open

Comments

@patcon
Copy link
Contributor

patcon commented Jun 5, 2013

Just thinking that sometime you don't want to bug your users every time a basebox updates, but you just want to make sure that you're all on the same version or updated past a certain build.

config.box_updater.acceptable_date = "> 1370454036"

So as I'm thinking, the warning would be silenced or auto-skipped if this condition matches.

Thoughts?

@spil-ruslan
Copy link
Owner

Not really sure if users will bother with setting date/time through configuration file. If you feel like you personally will benefit from it I can add this parameter as optional.

But I'm 100% agree with you that it's annoying to have such update notifications every time even if you decided to skip this update. To make it more user friendly for now I've changed plugin so if you decided to refuse update it will mark this update as one to be ignored and autoskip this update until next update detected.

This also should be available in version 0.0.3

Like this
1 First run with remote image updated:

[test] Verify remote image data: https://127.0.0.1/dummy.box
[test] Modified image detected : https://127.0.0.1/dummy.box {"Last-Modified"=>"Tue, 18 Jun 2013 11:33:11 GMT"}
Would you like to update the box? 
If negative - we keep ignoring this update, and notify only when another update detected. 
Type (Y/N)N 
[test] This update will be ignored

2 Next run:

[test] Verify remote image data: https://127.0.0.1/dummy.box
[test] Modified image detected, this update set to be ignored until next change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants