Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ruff linting rules #68

Closed
wants to merge 1 commit into from
Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 3, 2024

Short description

Add more ruff linting rules.
Also pre-commit autoupdate

Proposed changes

Resolved issues

Fixes: #65

@cclauss cclauss requested a review from timobrembeck as a code owner March 3, 2024 22:38
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e9d4308) to head (c8388ff).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          328       328           
=========================================
  Hits           328       328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cclauss
Copy link
Contributor Author

cclauss commented Mar 4, 2024

@dhruvmanila If you scroll to the bottom of pyproject.toml in this PR, you can see that GitHub is making the TOML format as invalid. Am I doing something wrong or is the GitHub TOML validation wrong?

@timobrembeck
Copy link
Collaborator

Looks like a GitHub issue to me, others also have similar problems:
https://github.com/orgs/community/discussions/110255

@cclauss cclauss closed this Aug 13, 2024
@cclauss cclauss deleted the more-ruff branch August 13, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ruff --select=DJ
2 participants