Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup: path resolution during 'sphinx.cmd.make_mode' cleanup #13158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixup: path resolution during 'sphinx.cmd.make_mode' cleanup #13158

wants to merge 2 commits into from

Conversation

jayaddison
Copy link
Contributor

@jayaddison jayaddison commented Nov 25, 2024 •
edited
Loading

Feature or Bugfix

  • Bugfix

Purpose

  • Fixup for make clean.

Detail

  • Remove redundant and incorrect double-resolution of build dir content paths.
  • Also, ensure that the resolved build dir is used to begin the cleanup search.

Relates

@jayaddison jayaddison requested a review from jfbu December 1, 2024 20:38
jfbu
jfbu approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@jfbu jfbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This said I tested only on macOS. (with Python 3.12)

@jayaddison
Copy link
Contributor Author

Thanks @jfbu - I'll add that I've tested this locally using Debian Linux, also using version 3.12 of Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfbu jfbu jfbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current master breaks make clean
2 participants
@jayaddison @jfbu