Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html search: add safety check before index property accesses #13153

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

html search: add safety check before index property accesses #13153

wants to merge 8 commits into from

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Purpose

  • Prevent queries for the JavaScript class prototype reference propery name from causing errors in the HTML search JavaScript code provided in the basic theme.

Detail

  • Ensure that the user input query term is found as a named property of the relevant index objects before accessing them, using Object.hasOwnProperty.

Relates

@jayaddison jayaddison added html search javascript Pull requests that update Javascript code labels Nov 24, 2024
@jayaddison jayaddison mentioned this pull request Nov 24, 2024
Closed
@jayaddison
Copy link
Contributor Author

Thank you @wlach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlach wlach wlach approved these changes

Assignees
No one assigned
Labels
html search javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML search: bug with JS-prototype-property query
2 participants
@jayaddison @wlach