Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fabian-Geyer
Copy link

Fixed Bug

AttributeError: 'NoneType' object has no attribute 'attrs'

when using :members: for sophisticated class

@joeced
Copy link
Collaborator

joeced commented Apr 7, 2024

Thanks for the contribution. Can you show me a case, where you get this error?

@Fabian-Geyer
Copy link
Author

The problem arises in Casos in the following folder: https://github.com/iFR-ACSO/casos/tree/main/%2Bcasos/%40PS for the PS class.
Thanks for the quick reply and the support.

@joeced
Copy link
Collaborator

joeced commented Apr 16, 2024

Phew... I finally had time to debug the issue. Your fix is not correct, the bug is even more subtle.
In the PS class your have inferior classes in package, the casadi.DM method for instance.

In line 141 of mat_documenters.py we would incorrectly lookup the method casadi. I fixed that, but the rendering is still off. We don't handle dotted member names correctly... yet :)

billede

@Fabian-Geyer
Copy link
Author

I'm very impressed! Thanks for the great work

@joeced
Copy link
Collaborator

joeced commented May 6, 2024

Hi again. Sorry for the late response. I'm struggling a bit on creating a simple example with inferior classes as the PS.m class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants