New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused parameter in copyFile function in unionFile #422

Open

nidhi-singh02 opened this issue Apr 2, 2024 · 0 comments

nidhi-singh02 commented Apr 2, 2024

In unionFile.go, at line no 270, copyFile function accepts a parameter named "base" https://github.com/spf13/afero/blob/5c4385aa20510dba5ca4db12c02b0c9211d82892/unionFile.go#L270C15-L270C19, which is not used.

Could be a good practice to remove it from the function definition. I could raise a PR for the same once issue is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment