Skip to content
This repository has been archived by the owner on Jul 12, 2021. It is now read-only.

Add the TXO's value to the response from get_mempool since we have it #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

doc-hex
Copy link

@doc-hex doc-hex commented Jun 22, 2016

The response from API call blockchain.address.get_mempool lists the transaction hashes but did not include the TXO amount, even though it's right there already (as 'delta').

This is a simple one-line change, which adds the additional data to the response, using the field name value to align with other responses.

Unfortunately, I don't have the means to test this change, and a number of API responses will be affected because they call get_unconfirmed_history() indirectly. Hopefully clients are going to ignore new JSON fields.

@lclc
Copy link

lclc commented Jun 22, 2016

get_mempool is not used by the Electrum-Client (or any other client I'm aware of) afaik, so shouldn't affect many users

For what do you use it?

@doc-hex
Copy link
Author

doc-hex commented Jun 22, 2016

I want to show a detailed balance of an address. For unconfirmed amounts it was not possible to show the breakdown of which transactions contribute how much to the unconfirmed balance.

This addition will also show up in blockchain.address.get_history for unconfirmed amounts.

@doc-hex
Copy link
Author

doc-hex commented Jun 20, 2017

Anniversary bump.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants