From 034c2ae11d9ec13576687eb38dbf6fc95efebf3e Mon Sep 17 00:00:00 2001
From: "Alexis \"spectria.limina\" Horizon" <spectria.limina@gmail.com>
Date: Tue, 3 Dec 2024 17:19:58 -0500
Subject: [PATCH] Fix waymarks and wasm.

We are good to go.
---
 Cargo.lock            | 24 ++++++++---------
 public/index.html     |  5 +++-
 src/main.rs           | 17 ++++++++----
 src/waymark/mod.rs    | 51 +++++++++++++----------------------
 src/waymark/window.rs | 62 ++++++++++++++++++++++++++++---------------
 5 files changed, 87 insertions(+), 72 deletions(-)
diff --git a/Cargo.lock b/Cargo.lock
index 1528879..9067188 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1656,9 +1656,9 @@ dependencies = [
 
 [[package]]
 name = "clap"
-version = "4.5.21"
+version = "4.5.22"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "fb3b4b9e5a7c7514dfa52869339ee98b3156b0bfb4e8a77c4ff4babb64b1604f"
+checksum = "69371e34337c4c984bbe322360c2547210bf632eb2814bbe78a6e87a2935bd2b"
 dependencies = [
  "clap_builder",
  "clap_derive",
@@ -1666,9 +1666,9 @@ dependencies = [
 
 [[package]]
 name = "clap_builder"
-version = "4.5.21"
+version = "4.5.22"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b17a95aa67cc7b5ebd32aa5370189aa0d79069ef1c64ce893bd30fb24bff20ec"
+checksum = "6e24c1b4099818523236a8ca881d2b45db98dadfb4625cf6608c12069fcbbde1"
 dependencies = [
  "anstream",
  "anstyle",
@@ -4418,7 +4418,7 @@ dependencies = [
  "ron",
  "serde",
  "serde_json",
- "thiserror 2.0.3",
+ "thiserror 2.0.4",
  "tracing",
  "wasm-bindgen",
  "web-sys",
@@ -4527,11 +4527,11 @@ dependencies = [
 
 [[package]]
 name = "thiserror"
-version = "2.0.3"
+version = "2.0.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c006c85c7651b3cf2ada4584faa36773bd07bac24acfb39f3c431b36d7e667aa"
+checksum = "2f49a1853cf82743e3b7950f77e0f4d622ca36cf4317cba00c767838bac8d490"
 dependencies = [
- "thiserror-impl 2.0.3",
+ "thiserror-impl 2.0.4",
 ]
 
 [[package]]
@@ -4547,9 +4547,9 @@ dependencies = [
 
 [[package]]
 name = "thiserror-impl"
-version = "2.0.3"
+version = "2.0.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f077553d607adc1caf65430528a576c757a71ed73944b66ebb58ef2bbd243568"
+checksum = "8381894bb3efe0c4acac3ded651301ceee58a15d47c2e34885ed1908ad667061"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -5704,9 +5704,9 @@ checksum = "b9cc00251562a284751c9973bace760d86c0276c471b4be569fe6b068ee97a56"
 
 [[package]]
 name = "xml-rs"
-version = "0.8.23"
+version = "0.8.24"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "af310deaae937e48a26602b730250b4949e125f468f11e6990be3e5304ddd96f"
+checksum = "ea8b391c9a790b496184c29f7f93b9ed5b16abb306c05415b68bcc16e4d06432"
 
 [[package]]
 name = "yansi"
diff --git a/public/index.html b/public/index.html
index 46b5cc6..9be0366 100644
--- a/public/index.html
+++ b/public/index.html
@@ -5,7 +5,10 @@
 </head>
 <body>
   <main>
-    <canvas id="stratmat" data-stramat-asset-root="/static/app/"></canvas>
+    <canvas id="stratmat" style="height: 100% !important; width: 100% !important"
+      data-stratmat-log-filter="stratmat::waymark=debug"
+      data-stratmat-asset-root="/static/app/assets/"></canvas>
+    </canvas>
   </main>
   <script type="module">
     import init from "/static/app/stratmat.js"
diff --git a/src/main.rs b/src/main.rs
index b0e7266..4f09d50 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -79,7 +79,11 @@ fn start(args: Args, primary_window: Window) -> eyre::Result<()> {
                     primary_window: Some(primary_window),
                     ..default()
                 })
-                .set(log_plugin),
+                .set(log_plugin)
+                .set(AssetPlugin {
+                    meta_check: bevy::asset::AssetMetaCheck::Never,
+                    ..default()
+                }),
         )
         .add_plugins(EguiPlugin)
         .add_plugins(Shape2dPlugin::default())
@@ -157,6 +161,8 @@ fn main() -> eyre::Result<()> {
 fn main() -> Result<(), JsValue> {
     use convert_case::{Case, Casing};
     use web_sys::console;
+    console::log_1(&"stratmat init: initializing...".into());
+
     let selector = option_env!("STRATMAT_CANVAS").unwrap_or_else(|| "#stratmat");
     let matches = web_sys::window()
         .unwrap()
@@ -164,18 +170,19 @@ fn main() -> Result<(), JsValue> {
         .unwrap()
         .query_selector_all(selector)?;
 
-    console::log_1(&format!("stratmat init: found {} canvases", matches.length()).into());
+    #[cfg(debug_assertions)]
+    console::log_1(&format!("stratmat init: found {} canvas(es)", matches.length()).into());
     let args = match matches.length() {
         0 => Args::parse(),
         1 => {
-            console::log_1(&"stratmat init: loading arguments from data attributes".into());
             let canvas: web_sys::HtmlCanvasElement =
                 matches.get(0).unwrap().dyn_into().map_err(|elem| {
                     format!("stratmat requires a <canvas>, not a <{}>", elem.node_name())
                 })?;
             let dataset = canvas.dataset();
             let keys = js_sys::Reflect::own_keys(&dataset)?;
-            let mut args = vec![];
+            // Arg 0 is the "process name"
+            let mut args = vec!["".to_owned()];
             for key in keys.iter() {
                 if let Some(name) = key
                     .as_string()
@@ -188,7 +195,7 @@ fn main() -> Result<(), JsValue> {
                 }
             }
             console::log_1(&format!("stratmat init: args: {:?}", args).into());
-            Args::parse_from(args)
+            Args::try_parse_from(args).map_err(|e| format!("invalid arguments: {e}"))?
         }
         _ => {
             return Err("multiple elements match selector '{CANVAS}'".into());
diff --git a/src/waymark/mod.rs b/src/waymark/mod.rs
index 2a4427a..bddb684 100644
--- a/src/waymark/mod.rs
+++ b/src/waymark/mod.rs
@@ -74,6 +74,7 @@ pub struct PresetEntry {
 #[derive(Copy, Clone, Debug, Hash, PartialOrd, Ord, PartialEq, Eq)]
 #[derive(Component, Reflect, Serialize, Deserialize)]
 #[derive(IntEnum, Sequence)]
+#[require(Transform, Visibility, Collider, CollidingEntities, AlphaScale)]
 pub enum Waymark {
     A = 0,
     B = 1,
@@ -183,35 +184,6 @@ impl Waymark {
     }
 }
 
-#[derive(Bundle)]
-struct WaymarkBundle {
-    name: Name,
-    waymark: Waymark,
-    transform: Transform,
-    visibility: Visibility,
-    collider: Collider,
-    colliding: CollidingEntities,
-    alpha: AlphaScale,
-}
-
-impl WaymarkBundle {
-    fn new(waymark: Waymark) -> Self {
-        Self {
-            name: Name::new(waymark.name()),
-            waymark,
-            transform: default(),
-            visibility: default(),
-            collider: if waymark.is_square() {
-                Collider::rectangle(WAYMARK_SIZE, WAYMARK_SIZE)
-            } else {
-                Collider::circle(WAYMARK_SIZE / 2.0)
-            },
-            colliding: default(),
-            alpha: default(),
-        }
-    }
-}
-
 struct InsertWaymark {
     waymark: Waymark,
     entry: Option<PresetEntry>,
@@ -228,7 +200,6 @@ impl EntityCommand for InsertWaymark {
             let mut arena_q = world.query::<&ArenaBackground>();
             match arena_q.get_single(world) {
                 Ok(arena) => {
-                    debug!("positioning waymark {waymark:?} when arena loaded");
                     world.run_system_when_asset_loaded_with(
                         arena.handle.id(),
                         set_position_from_preset,
@@ -244,8 +215,17 @@ impl EntityCommand for InsertWaymark {
         let Ok(mut entity) = world.get_entity_mut(id) else {
             return;
         };
-        entity.insert(WaymarkBundle::new(waymark));
+        entity.insert((
+            Name::new(waymark.name()),
+            waymark,
+            if waymark.is_square() {
+                Collider::rectangle(WAYMARK_SIZE, WAYMARK_SIZE)
+            } else {
+                Collider::circle(WAYMARK_SIZE / 2.0)
+            },
+        ));
         make_draggable_world(&mut entity);
+
         entity.with_children(|parent| {
             parent.spawn((
                 Name::new("Waymark Image"),
@@ -317,6 +297,12 @@ fn set_position_from_preset(
     let Ok(mut entity) = world.get_entity_mut(id) else {
         return;
     };
+    let (x, y) = (entry.x - offset.x, offset.y - entry.z);
+    debug!(
+        "arena loaded, repositioning waymark {} to {:?}",
+        entry.id,
+        (x, y),
+    );
     entity.insert(Transform::from_xyz(
         entry.x - offset.x,
         // The entry's Z axis is our negative Y axis.
@@ -325,8 +311,7 @@ fn set_position_from_preset(
     ));
 }
 
-/// [`EntityCommand`] to insert a waymark's entities.
-///
+//
 /// If a [`PresetEntry`] is provided, it will be used to position the waymark.
 pub fn insert_waymark(waymark: Waymark, entry: Option<PresetEntry>) -> impl EntityCommand {
     InsertWaymark { waymark, entry }
diff --git a/src/waymark/window.rs b/src/waymark/window.rs
index 1dffe73..df22615 100644
--- a/src/waymark/window.rs
+++ b/src/waymark/window.rs
@@ -4,7 +4,7 @@ use bevy::ecs::system::SystemState;
 use bevy::prelude::*;
 
 use bevy::utils::hashbrown::HashMap;
-use bevy_egui::egui::TextEdit;
+use bevy_egui::egui::{RichText, TextEdit};
 use bevy_egui::{egui, EguiClipboard, EguiContexts};
 
 use super::{Preset, Waymark};
@@ -40,29 +40,16 @@ impl WaymarkWindow {
             let (id, mut win) = win_q.single_mut();
 
             ui.horizontal(|ui| {
-                ui.label("Preset: ");
-                ui.add(TextEdit::singleline(&mut win.preset_name).desired_width(100.0));
+                ui.label("Preset Name: ");
+                ui.add(TextEdit::singleline(&mut win.preset_name).desired_width(80.0));
             });
             ui.horizontal(|ui| {
                 if ui.button("Import").clicked() {
-                    if let Some(contents) = clipboard.get_contents() {
-                        match serde_json::from_str::<Preset>(&contents) {
-                            Ok(preset) => {
-                                win.preset_name = preset.name.clone();
-                                commands.run_system_cached(Waymark::despawn_all);
-                                Waymark::spawn_from_preset(&mut commands, preset);
-                                info!(
-                                    "Imported waymark preset '{}' from the clipboard",
-                                    win.preset_name
-                                );
-                            }
-                            Err(e) => {
-                                info!("Unable to import waymark preset: {}", e);
-                            }
-                        }
-                    } else {
-                        info!("Unable to import waymark preset: clipboard is empty")
-                    }
+                    Self::import_from_clipboard(
+                        &mut win.preset_name,
+                        &mut clipboard,
+                        &mut commands,
+                    );
                 }
                 if ui.button("Export").clicked() {
                     commands.run_system_cached(Self::export_to_clipboard);
@@ -71,6 +58,8 @@ impl WaymarkWindow {
                     commands.run_system_cached(Waymark::despawn_all);
                 }
             });
+            #[cfg(target_arch = "wasm32")]
+            ui.label(RichText::new("To paste, press Ctrl-C then click Import.").italics());
 
             let spawners: HashMap<_, _> = spawner_q
                 .iter_mut()
@@ -95,6 +84,37 @@ impl WaymarkWindow {
         });
     }
 
+    fn import_from_clipboard(
+        preset_name: &mut String,
+        clipboard: &mut EguiClipboard,
+        commands: &mut Commands,
+    ) {
+        let Some(contents) = clipboard.get_contents() else {
+            info!("Unable to import waymarks: clipboard unavailable");
+            return;
+        };
+
+        if contents.is_empty() {
+            info!("Unable to import waymarks: clipboard is empty (or unavailable)");
+            return;
+        }
+
+        match serde_json::from_str::<Preset>(&contents) {
+            Ok(preset) => {
+                *preset_name = preset.name.clone();
+                commands.run_system_cached(Waymark::despawn_all);
+                Waymark::spawn_from_preset(commands, preset);
+                info!(
+                    "Imported waymark preset '{}' from the clipboard",
+                    preset_name
+                );
+            }
+            Err(e) => {
+                info!("Unable to import waymarks: invalid preset: {}", e);
+            }
+        }
+    }
+
     /// [System] that exports the currently-spawned waymarks to the clipboard.
     pub fn export_to_clipboard(
         win_q: Query<&WaymarkWindow>,
