Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Joinpoints.ts generation to integrate with Event System #68

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

racoelhosilva
Copy link

Updated Joinpoints.ts generation to integrate with Event System

References

  • Due to the developments in the History of Transformation for the Clava tool, a new event system was introduced in the Joinpoints.ts file, therefore, the generation of the file should also be updated
  • Before merging this pull request, it might be adequate to also merge this one

This work is related to the topic [CSE02] Recording the History of Source-to-Source Transformations, which is part of the INESC TEC Summer Internship 2024

@joaobispo joaobispo changed the base branch from feature/lara-js to staging August 12, 2024 15:42
Comment on lines +65 to +66
import eventListener from "./clava/events/EventListener.js";
import { Event, EventTime } from "./clava/events/Events.js";\n\n`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LARA framework should not know about the existence of Clava, which uses it. This is a sign that the events code currently in the Clava repository should be moved to the LARA framework repository, into the adequate folder.

I suggest moving moving the files to lara-framework/Lara-JS/src-api/lara/events and update imports accordingly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the code in PR#157, it is not immediately possible to move the code the the lara-framework, it would need further refactoring in order to separate the Events interface from the Clava-specific implementation.

@lm-sousa
Copy link
Member

lm-sousa commented Aug 22, 2024 via email

@lm-sousa
Copy link
Member

I recommend keeping the branch reference so the work isn't lost, but not merging as to not pollute the project with unfinished code.

This is a good start but still has a long way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants