You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have multiple projects still running Laravel 8. I'm updating the Composer dependencies and switching to this new fancy ignition output. Love it!
Only one little thing. If the exception is not an Illuminate type, the LaravelDocumentationLinkFinder will return null as result. Could we return "https://laravel.com/docs/{$majorVersion}.x" instead if we do not have a type and as default match? That way the documentation link is always opening a documentation tab to the correct version.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
We have multiple projects still running Laravel 8. I'm updating the Composer dependencies and switching to this new fancy ignition output. Love it!
Only one little thing. If the exception is not an Illuminate type, the LaravelDocumentationLinkFinder will return
null
as result. Could we return"https://laravel.com/docs/{$majorVersion}.x"
instead if we do not have a type and as default match? That way the documentation link is always opening a documentation tab to the correct version.Beta Was this translation helpful? Give feedback.
All reactions