Merge pull request #235 from raveren/main

Fix value omitted when input created with no name
spatie · Jul 3, 2024 · c7f4e6f · c7f4e6f
2 parents 10f40ba + 72066a9
commit c7f4e6f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/Html.php b/src/Html.php
@@ -256,7 +256,7 @@ public function element($tag)
      */
     public function input($type = null, $name = null, $value = null)
     {
-        $hasValue = $name && ($type !== 'password' && ! is_null($this->old($name, $value)) || ! is_null($value));
+        $hasValue = ! is_null($value) || ($type !== 'password' && ! is_null($this->old($name, $value)));
 
         return Input::create()
             ->attributeIf($type, 'type', $type)

diff --git a/tests/Html/InputTest.php b/tests/Html/InputTest.php
@@ -28,6 +28,13 @@
     );
 });
 
+it('can create an input with no name and a value', function () {
+    assertHtmlStringEqualsHtmlString(
+        '<input type="text" value="bar">',
+        $this->html->input('text', null, 'bar')
+    );
+});
+
 it('can create an input with a placeholder', function () {
     assertHtmlStringEqualsHtmlString(
         '<input placeholder="Foo bar">',