Add boost parameter to Terms query #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dam-bal
reviewed
Oct 24, 2024
src/Queries/TermsQuery.php
Outdated
| 'terms' => [ | ||
| $this->field => $this->value, | ||
| ], | ||
| ]; | ||
|
|
||
| if ($this->boost) { |
There was a problem hiding this comment.
what if we want to apply boost of 0? this won't work as expected, it would be better to check if it's not null instead
There was a problem hiding this comment.
Great suggestion. I thought I'd keep it in line with the existing MatchQuery but this is better. I've updated the MatchQuery as well now, or would you like a separate PR for this?
bram-pkg
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TermsQuery, similar to Add boost parameter to MatchQuery #42.MatchQueryto check for not null values instead of falsy values.