Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max crawl depth not working #475

Closed
sasa-andjelic-nqode opened this issue Sep 18, 2024 · 0 comments
Closed

Max crawl depth not working #475

sasa-andjelic-nqode opened this issue Sep 18, 2024 · 0 comments

Comments

@sasa-andjelic-nqode
Copy link

When I start a crawl without setting the max crawl depth, the crawler scans for links on all pages.
But when I set the max crawl depth to some int value (for example 100), the crawler only scans the first layer of links and crawls those.

I took a peek into Crawler->addToDepthTree() implementation and I see that if the max depth is null any url is instanciated as node. The rest of the conditions inside the method implementation do not cover a case for child links.
I also didn't notice any increment for current depth of the link.

It looks like max depth was never implemented completely. Is it that or am I perhaps missing something obvious which I should pay attention to?

@spatie spatie locked and limited conversation to collaborators Dec 11, 2024
@freekmurze freekmurze converted this issue into discussion #482 Dec 11, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant