Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Carousel #117

Closed
1 of 2 tasks
goetzrobin opened this issue Jan 11, 2024 · 4 comments · Fixed by #160
Closed
1 of 2 tasks

RFC: Carousel #117

goetzrobin opened this issue Jan 11, 2024 · 4 comments · Fixed by #160
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@goetzrobin
Copy link
Collaborator

Which scope/s are relevant/related to the feature request?

Don't know / other

Information

TBD

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@goetzrobin goetzrobin added the enhancement New feature or request label Jan 11, 2024
@goetzrobin
Copy link
Collaborator Author

We will wrap around the official Angular wrapper: davidjerleke/embla-carousel#627

@goetzrobin
Copy link
Collaborator Author

This is now possible with the following official Angular wrapper: https://github.com/donaldxdonald/embla-carousel-angular

@goetzrobin goetzrobin added the help wanted Extra attention is needed label Feb 13, 2024
@theo-matzavinos
Copy link
Contributor

I took a stab at this since it seemed pretty straightforward. The API I went with looks like this:

   <hlm-carousel orientation="horizontal" [plugins]="emblaPlugins">
      <hlm-carousel-content>
        <hlm-carousel-item>...</hlm-carousel-item>
        <hlm-carousel-item>...</hlm-carousel-item>
      </hlm-carousel-content>
      <button hlm-carousel-previous></button>
      <button hlm-carousel-next></button>
    </hlm-carousel>

Let me know if this is the direction you had in mind and if I should open a PR.

@goetzrobin
Copy link
Collaborator Author

looks awesome! One thing I'd might change is the directives for the buttons to become: hlmCarouselPrevious and hlmCarouselNext. Looking forward to your PR @theo-matzavinos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants