Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is PC matrix multiplied by cdelt1 to get CD matrix #126

Open
mcara opened this issue Jun 10, 2020 · 0 comments
Open

Why is PC matrix multiplied by cdelt1 to get CD matrix #126

mcara opened this issue Jun 10, 2020 · 0 comments
Labels

Comments

@mcara
Copy link
Member

mcara commented Jun 10, 2020

In pc2cd() function in hstwcs.py, conversion from PC to CD matrix is performed by multiplying PC matrix by cdelt[1], which is not what should be done mathematically:

def pc2cd(self):
if self.wcs.has_pc():
self.wcs.cd = self.wcs.pc * self.wcs.cdelt[1]

What is the reason for this?

CC: @nden @stsci-hack

@mcara mcara added the question label Jun 10, 2020
@mcara mcara changed the title Why PC is multiplied by cdelt1 to get CD matrix Why is PC matrix multiplied by cdelt1 to get CD matrix Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant