-
Notifications
You must be signed in to change notification settings - Fork 28
Pull Request Checklist
Zach Burnett edited this page Sep 6, 2024
·
6 revisions
- request a review from someone specific, to avoid making the maintainers review every PR
- add a build milestone, i.e.
24Q4_B15(use the latest build if not sure) - Does this PR change user-facing code / API?
- add an entry to
CHANGES.rstwithin the relevant release section (otherwise add theno-changelog-entry-neededlabel to this PR) - update or add relevant tests
- update relevant docstrings and / or
docs/page - start a regression test and include a link to the running job (click here for instructions)
- Do truth files need to be updated ("okified")?
- after the reviewer has approved these changes, run
okify_regteststo update the truth files
- after the reviewer has approved these changes, run
- Do truth files need to be updated ("okified")?
- add an entry to
- if a JIRA ticket exists, make sure it is resolved properly